Check if ref'd resource is selected before favoring state #10108
+32
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10108 +/- ##
==========================================
- Coverage 88.23% 88.19% -0.05%
==========================================
Files 181 181
Lines 22770 22770
==========================================
- Hits 20092 20081 -11
- Misses 2678 2689 +11
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
jtcohen6
commented
May 8, 2024
| # User has explicitly opted to prefer defer_relation for unselected resources | ||
| ( | ||
| self.config.args.favor_state | ||
| and target_model.unique_id not in selected_resources.SELECTED_RESOURCES |
There was a problem hiding this comment.
This is a global (ew), and has been for a while:
MichelleArk
approved these changes
May 8, 2024
github-actions bot
pushed a commit
that referenced
this pull request
May 8, 2024
* Add test case * Check if ref'd resource is selected before favoring state * Add changie (cherry picked from commit 84cc540)
jtcohen6
added a commit
that referenced
this pull request
May 9, 2024
…10114) * Add test case * Check if ref'd resource is selected before favoring state * Add changie (cherry picked from commit 84cc540) Co-authored-by: Jeremy Cohen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #10107
Problem
Previous behavior of
--favor-state+--defer, when selecting multiple resources that build on top of each other, was to favor state for only unselected resources.The recent deferral refactors (#9040 + #9199) implicitly changed this behavior, by favoring state always.
Solution
Check to see whether a referenced node is selected (using
selected_resourcesglobal) before favoring state (defer_relation).I have added a test case that:
1.7.latest(86df655)mainChecklist